-
Notifications
You must be signed in to change notification settings - Fork 790
Allow to configure from-tag in register #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm afraid the |
|
nice to hear of you @ibc -- you are certainly right that the From-tag must be random (RFc3261 19.3 The bottom line is we are interested in this because it helps SIp troubleshooting, which is inherently a different enterprise, by linking a piece of information in SIP message to information found in analytics. For empirical reasons, from-tag is actually a practical place to do this -- while not guaranteed to survive, it occurs to traverse SBCs unchanged more often than proprietary header-fields or CAll-id. anyhow don't feel compelled to adopt the patch, it is a very specific use-case, I just wanted to make the point that of course the tag will be generated randomly and neither is it a password -- it is to be used as a random, unique often-surviving reference number. |
|
actually here another text making the point, section 19.3, which specifically encourages implementations to relate context to the otherwise opaque tag: the principle is the same -- use additional properties of the tag for relate additional context to it |
|
Thanks. I'll reopen the PR but AFAIU the new setting should be named
Each REGISTER will have a From tag as follows:
Does it make sense? |
|
thank you @ibc , almost there -- i think it makes sense to guarantee random properties by the mandatory part and permit some additional uses by an optional prefix. what would really help us is a capability to introduce a suffix that is variable -- it could specifically depend on source-ip, timestamp, config parameter, so that's easy to relate to any of these elements. how would you feel about using a function ?: |
OK done. @ibc please review The |
|
Hi guys, busy these days, will take a look to this soon. |
|
Thanks @kkozlik, merged. It'll be available in the next release. |
Allow to configure from-tag in register
We need to configure from-tag send in REGISTER messages. This PR is adding the ability to configure it via UA configuration.